Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rated Disabilities] Integrate new LH endpoint behind feature flag #26923

Merged
merged 50 commits into from
Feb 28, 2024

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Nov 30, 2023

Summary

Adding versions of the UI components to be used with Lighthouse behind the rd_use_lighthouse feature toggle

Related issue(s)

Testing Steps

vets-api

Note: Make sure to pull the latest vets-api-mockdata and vets-api

  1. Open settings.local.yml
  2. Add the below:
lighthouse:
  veteran_verification:
    host: https://staging-api.va.gov
    form526:
      host: https://staging-api.va.gov
    use_mocks: true

vets-website

Note: Make sure that the rated_disabilities_use_lighthouse feature flag is enabled

  1. Log in using mocked auth here
  1. Navigate to http://localhost:3001/disability/view-disability-rating/rating

Testing done

Added specs for new components

Screenshots

Screenshot 2024-02-26 at 3 42 23 PM

What areas of the site does it impact?

Rated Disabilities Application

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this Nov 30, 2023

const facilityLocatorUrl = getAppUrl('facilities');

const renderMVIError = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice much cleaner!

@va-vfs-bot va-vfs-bot temporarily deployed to master/63310-use-lighthouse-2/main November 30, 2023 16:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/63310-use-lighthouse-2/main November 30, 2023 17:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/63310-use-lighthouse-2/main December 14, 2023 17:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/63310-use-lighthouse-2/main February 21, 2024 17:18 Inactive
@jerekshoe jerekshoe marked this pull request as ready for review February 27, 2024 20:40
@jerekshoe jerekshoe requested review from a team as code owners February 27, 2024 20:40

import { missingTotalMessage } from './TotalRatingStates';

export default function CombinedRating({ combinedRating }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a screen shot of this and/or a video showing that the link works as expected.
Also looks like we still need a test file and tests for this new component.

@@ -3,14 +3,13 @@ import { CONTACTS } from '@department-of-veterans-affairs/component-library/cont

export default function NeedHelp() {
return (
<va-need-help class="vads-u-margin-y--3" uswds="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a ticket/pr for this uswds work so I wouldnt update here its out of scope


export default function NoCombinedRating() {
return (
<va-alert status="info" uswds>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are adding a new va-alert to rated disabilities that has uswds enabled then we will want to update the ticket here and spreadsheet here to make sure we account for this work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to spreadsheet


export default function NoRatings() {
return (
<va-alert uswds>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are adding a new va-alert to rated disabilities that has uswds enabled then we will want to update the ticket department-of-veterans-affairs/va.gov-team#76124 and spreadsheet here to make sure we account for this work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to spreadsheet


export default function ServerError() {
return (
<va-alert status="error" uswds>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are adding a new va-alert to rated disabilities that has uswds enabled then we will want to update the ticket department-of-veterans-affairs/va.gov-team#76124 and spreadsheet here to make sure we account for this work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to spreadsheet

// cy.findByText(/We don’t have rated disabilities on file for you/).should(
// 'exist',
// );
// };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these commented tests?

@jerekshoe jerekshoe merged commit 79ea215 into main Feb 28, 2024
139 of 140 checks passed
@jerekshoe jerekshoe deleted the 63310-use-lighthouse-2 branch February 28, 2024 16:15
pjhill pushed a commit that referenced this pull request Mar 14, 2024
…26923)

* Adding UI elements that are compatible with the Lighthouse response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet