-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rated Disabilities] Integrate new LH endpoint behind feature flag #26923
Conversation
|
||
const facilityLocatorUrl = getAppUrl('facilities'); | ||
|
||
const renderMVIError = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice much cleaner!
src/applications/rated-disabilities/components/CombinedRating.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/CombinedRating.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/CombinedRating.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/FeatureFlagsLoaded.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/RatingList/ListItem.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/RatingList/RatingList.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/RatingList/Section.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/RatingList/index.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/TotalRatedDisabilities.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/evss/RatedDisabilityList.jsx
Outdated
Show resolved
Hide resolved
|
||
import { missingTotalMessage } from './TotalRatingStates'; | ||
|
||
export default function CombinedRating({ combinedRating }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a screen shot of this and/or a video showing that the link works as expected.
Also looks like we still need a test file and tests for this new component.
src/applications/rated-disabilities/components/RatingLists/RatingLists.jsx
Outdated
Show resolved
Hide resolved
src/applications/rated-disabilities/components/RatingLists/RatingLists.jsx
Show resolved
Hide resolved
@@ -3,14 +3,13 @@ import { CONTACTS } from '@department-of-veterans-affairs/component-library/cont | |||
|
|||
export default function NeedHelp() { | |||
return ( | |||
<va-need-help class="vads-u-margin-y--3" uswds="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a ticket/pr for this uswds work so I wouldnt update here its out of scope
|
||
export default function NoCombinedRating() { | ||
return ( | ||
<va-alert status="info" uswds> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to spreadsheet
|
||
export default function NoRatings() { | ||
return ( | ||
<va-alert uswds> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are adding a new va-alert to rated disabilities that has uswds enabled then we will want to update the ticket department-of-veterans-affairs/va.gov-team#76124 and spreadsheet here to make sure we account for this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to spreadsheet
|
||
export default function ServerError() { | ||
return ( | ||
<va-alert status="error" uswds> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are adding a new va-alert to rated disabilities that has uswds enabled then we will want to update the ticket department-of-veterans-affairs/va.gov-team#76124 and spreadsheet here to make sure we account for this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to spreadsheet
// cy.findByText(/We don’t have rated disabilities on file for you/).should( | ||
// 'exist', | ||
// ); | ||
// }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need these commented tests?
…26923) * Adding UI elements that are compatible with the Lighthouse response
Summary
Adding versions of the UI components to be used with Lighthouse behind the
rd_use_lighthouse
feature toggleRelated issue(s)
[Rated Disabilities to Lighthouse] Implement FE changes va.gov-team#63310
Testing Steps
vets-api
Note: Make sure to pull the latest
vets-api-mockdata
andvets-api
settings.local.yml
vets-website
Note: Make sure that the
rated_disabilities_use_lighthouse
feature flag is enabledTesting done
Added specs for new components
Screenshots
What areas of the site does it impact?
Rated Disabilities Application
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?