Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form-labels.md #2434

Merged
merged 8 commits into from
May 13, 2024
Merged

Update form-labels.md #2434

merged 8 commits into from
May 13, 2024

Conversation

megzehn
Copy link
Collaborator

@megzehn megzehn commented Jan 29, 2024

Adding a note that our form label page is in progress

Adding a note that our form label page is in progress
@humancompanion-usds
Copy link
Collaborator

@megzehn - Is this ready? Can you hit the "Ready for review" button if so?

@megzehn
Copy link
Collaborator Author

megzehn commented May 1, 2024

Hi @humancompanion-usds, this is not ready yet. After I drafted these changes, we decided to shift our work to revising the labels instead. Now that we have some updated on the Patterns page, we can probably iterate on this message and point to those. I'll work on this with Laura and Danielle and mark it for review when it's ready!

adding links to new labels
added more links
adding a link to the Content style guide form labels page
shortened intro and added same copy from content side
@@ -6,18 +6,13 @@ slug: form-labels

# Form labels (in progress)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humancompanion-usds, will changing this H1 impact the URL for this page?

@megzehn megzehn marked this pull request as ready for review May 2, 2024 19:45
@megzehn megzehn requested a review from a team as a code owner May 2, 2024 19:45
@megzehn
Copy link
Collaborator Author

megzehn commented May 2, 2024

Hi @humancompanion-usds, I reviewed this with Laura and Danielle and it's ready for you now!

Let me know if you have any concerns. Thank you.

@humancompanion-usds humancompanion-usds merged commit a730df0 into main May 13, 2024
6 checks passed
@humancompanion-usds humancompanion-usds deleted the megzehn-formlabels branch May 13, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants