VACMS-17817 Resources & Support va-icon cleanup #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
randimays
force-pushed
the
17817-resources-support-icon
branch
from
80ba081
to
f7d91af
Compare
laflannery
approved these changes
May 17, 2024
jtmst
approved these changes
May 17, 2024
micahchiang
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Resources & Support icons on the content-build side to
va-icon.Related issue(s)
Testing done
Tested locally.
In order to test the
media_list_imagestemplate, you need to runyarn previewlocally and go tolocalhost:3002/?preview?nodeId=6954. There is no production content for this template, but it only exists on the R&S page and we do have some content in lower environments.The icon in the
list_of_linkstemplate was left behind when we converted theGo to all articleslinks to active va-links. The icon wasn't showing up visually, but it is in the DOM in prod. See screenshots in the below section. This can be tested at/resources.The
browse_by_audiencetemplate isn't used in prod, but when it is implemented, it looks just like the browse by topic section, so as long as that section is working ok and implemented identically in thebrowse_by_audiencetemplate, we can have confidence it will work if it is implemented.Screenshots
media_list_images (not production content)
list_of_links
In production
The icon is present next to the active link, but it does not appear
Locally
The icon that is not appearing has been removed and the active link still works