event icon updated

[jtmst]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

relates to department-of-veterans-affairs/vets-website#29769

Summary

• Updates events recurring event icon to va-icon

Related issue(s)

• Events: upgrade to va-icon va.gov-cms#17822

Testing done

• local visual

Screenshots

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

• The header does not contain any web-components
• I used the proxy-rewrite steps to test the injected header scenario
• I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[laflannery]

@jtmst a few comments/questions:

• There is an extra aria-hidden attribute on the actual icon component, this isn't needed
• I noticed that some icons weren't updated but I'm also not sure if they are included in this ticket or they are accounted for in another:
  • The social icons
  • The repeat icon on the Events listing page

[jtmst]

@jtmst a few comments/questions:

• There is an extra aria-hidden attribute on the actual icon component, this isn't needed

• I noticed that some icons weren't updated but I'm also not sure if they are included in this ticket or they are accounted for in another:

  • The social icons
  • The repeat icon on the Events listing page

Added changes for the social links. I can also do event listings with this ticket if that makes most sense, but it needs to be a separate PR as event listings live in vets-website

[laflannery]

@jtmst The calendar icon shouldn't have been included here - because there is a calendar <va-link> option that includes the icon. That is the component that is being used currently on prod and the DST would be responsible for updating any icon within a component. Can we put that back?

Otherwise, everything else looks good

[laflannery]

No I Lied above! The Twitter logo should be using the new X logo! Do we have that available in the new va-icon set? Would it also be possible - I know it's slightly out of scope - but could we update the link text to say "Share on X (formerly Twitter)" as well? Definitely say no if that's too much

[laflannery]

Approved - noting that the slight misalignment of the Calendar icon and the other social icons should be resolved next week when the DST updates to use