Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 entry for 686c #2068

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add v2 entry for 686c #2068

wants to merge 1 commit into from

Conversation

DLarson-Oddball
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • Adds entry point for 686c v2

Related issue(s)

department-of-veterans-affairs/va.gov-team#81049

Testing done

Visited /view-change-dependents/add-remove-form-21-686c-v2 and saw form application load

Screenshots

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants