VACMS-17821 Campaign Landing Pages va-icon update #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
17821-CLPs-icon
branch
2 times, most recently
from
ba99491
to
d323abe
Compare
randimays
force-pushed
the
17821-CLPs-icon
branch
3 times, most recently
from
ab5df4f
to
ee71686
Compare
randimays
force-pushed
the
17821-CLPs-icon
branch
5 times, most recently
from
edf1073
to
004f1a6
Compare
|
@randimays just one update - on the social icons in the get updates section, there is the extra |
|
@randimays For the benefit hub icons, can we set the circle background to 40 px to give the icon more room? This was suggested in a Slack thread and Amanda approved this approach. |
randimays
force-pushed
the
17821-CLPs-icon
branch
from
004f1a6
to
067808b
Compare
randimays
force-pushed
the
17821-CLPs-icon
branch
from
067808b
to
c16674b
Compare
|
@laflannery @thejordanwood Review instance is up and ready for your review please! |
jtmst
approved these changes
May 21, 2024
harshil1793
approved these changes
May 22, 2024
maxx1128
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update all the icons on Campaign Landing pages to use
<va-icon>.Related issue(s)
department-of-veterans-affairs/va.gov-cms#17821
Testing done
Tested locally these CLPs:
/initiatives/vote//initiatives/veterans-experience-action-centers//initiatives/protecting-veterans-from-fraud//initiatives/veteran-trust-in-va//initiatives/covid-flu//initiatives/end-of-life-benefits//initiatives/sign-in-securely-with-logingov//initiatives/emergency-room-911-or-urgent-care/Screenshots
Hub icons
Social icons