Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font size for feedback button due to changes to base font-size change #2011

Merged
merged 7 commits into from
May 20, 2024

Conversation

powellkerry
Copy link
Contributor

Summary

The base font-size specified in the @department-of-veterans-affairs/formation package will be changed from 10px to 16px. This change updates the font-size of the feedback button to adjust to that change

This change will be merged with the other PRs in the related issue.

Related issue(s)

department-of-veterans-affairs/vets-design-system-documentation#2681

Testing done

Local testing and verification, testing will also be done in a review instance

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Desktop Screenshot 2024-04-09 at 9 41 11 AM Screenshot 2024-04-09 at 9 41 54 AM

What areas of the site does it impact?

Feedback button

Acceptance criteria

Quality Assurance & Testing

  • [x ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [ x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [x ] Linting warnings have been addressed
  • [ x] Documentation has been updated (link to documentation *if necessary)
  • [ x] Screenshot of the developed feature is added
  • [x ] Accessibility testing has been performed

Error Handling

  • [ x] Browser console contains no warnings or errors.
  • [x ] Events are being sent to the appropriate logging solution
  • [x ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • [ x] Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • [x ] The header does not contain any web-components
  • [x ] I used the proxy-rewrite steps to test the injected header scenario
  • [x ] I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/66753-formation-typography-updates May 6, 2024 21:56 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/66753-formation-typography-updates May 7, 2024 23:00 Inactive
@powellkerry powellkerry merged commit aac721c into main May 20, 2024
24 checks passed
@powellkerry powellkerry deleted the 66753-formation-typography-updates branch May 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants