Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MHV-55425] added new app to registry. #1995

Closed
wants to merge 2 commits into from

Conversation

robertbylight
Copy link
Contributor

@robertbylight robertbylight commented Mar 29, 2024

Summary

Work related to isolating the mhv medications app under the applications directory

  • added new app to registry

Related issue(s)

Integrated Apps - Medications - Copy the code to the new shared location

Isolated Apps - RX - Copy the Code to the new shared location

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/mhv-55425-isolate-medications-registry April 1, 2024 23:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/mhv-55425-isolate-medications-registry April 2, 2024 15:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/mhv-55425-isolate-medications-registry April 2, 2024 15:29 Inactive
@robertbylight
Copy link
Contributor Author

no longer needed since the git move was successfully done without the need for an extra app as backup

@robertbylight robertbylight deleted the mhv-55425-isolate-medications-registry branch May 20, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants