Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update content-build to web components 6.0.0 #1971

Merged
merged 4 commits into from Mar 26, 2024
Merged

update content-build to web components 6.0.0 #1971

merged 4 commits into from Mar 26, 2024

Conversation

micahchiang
Copy link
Contributor

Description

This pull request updates the content-build dependency for web components to 6.0.0, which includes all web components rendering their V3 variants by default

@micahchiang
update content-build to web components 6.0.0
b03d9dd 
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@micahchiang micahchiang requested review from a team as code owners March 18, 2024 19:19
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/mc-web-component-version-update March 18, 2024 20:34 Inactive
randimays
randimays approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jilladams jilladams requested review from a team March 19, 2024 16:41
eselkin
eselkin approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure that the web-components in content-build actually get used on build, maybe in preview. Is there actually a step where they get pulled in in metalsmith or do they get pulled in from vets-website?

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/mc-web-component-version-update March 19, 2024 17:28 Inactive
@micahchiang micahchiang merged commit 654a65b into main Mar 26, 2024
23 checks passed
@micahchiang micahchiang deleted the mc-web-component-version-update branch March 26, 2024 18:49
@micahchiang micahchiang mentioned this pull request Mar 26, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamigibbs jamigibbs jamigibbs approved these changes

@eselkin eselkin eselkin approved these changes

@randimays randimays randimays approved these changes

@chriskim2311 chriskim2311 chriskim2311 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@micahchiang @jamigibbs @eselkin @randimays @chriskim2311 @va-vfs-bot