Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pensions breadcrumb title #1940

Merged
merged 2 commits into from Mar 4, 2024
Merged

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Mar 1, 2024

Summary

Updates the copy for the breadcrumbs across all Pension form pages to be: Apply for Veterans Pension benefits.

It was Apply for Veterans' pension benefits, but the style guide says to use "Veterans Pension" with capitalized P and no apostrophe.

Related issue(s)

department-of-veterans-affairs/va.gov-team#74451

Testing done

  • Ran yarn build and yarn watch locally for vets-website. Confirmed that the breadcrumbs matched the new copy.

Screenshots

Before After
Desktop Screenshot 2024-03-01 at 9 29 22 AM Screenshot 2024-03-01 at 9 15 21 AM

What areas of the site does it impact?

Pension Benefits

Acceptance criteria

department-of-veterans-affairs/va.gov-team#74451

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/pensions-74451-breadcrumb-update March 1, 2024 14:30 Inactive
@TaiWilkin TaiWilkin added the pension-benefits Project related work for VA Pension (527EZ) label Mar 1, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/pensions-74451-breadcrumb-update March 1, 2024 20:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/pensions-74451-breadcrumb-update March 4, 2024 14:11 Inactive
@TaiWilkin TaiWilkin merged commit dae44d3 into main Mar 4, 2024
25 checks passed
@TaiWilkin TaiWilkin deleted the pensions-74451-breadcrumb-update branch March 4, 2024 19:32
reiting pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pension-benefits Project related work for VA Pension (527EZ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants