-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-17196 R&S Detail Page component upgrade to V3 #1934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-of-veterans-affairs/content-build into 17196-rs-detail-component-upgrade
chriskim2311
changed the title
17196 rs detail component upgrade
VACMS-17196 R&S Detail Page component upgrade to V3
Feb 28, 2024
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
February 28, 2024 20:21
Inactive
PR has failing required tests, opting not to review at this time. - Tier 2/FE COP |
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 4, 2024 21:36
Inactive
This reverts commit d9b8443.
…ent-build into 17196-rs-detail-component-upgrade
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 5, 2024 18:56
Inactive
…ent-build into 17196-rs-detail-component-upgrade
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 6, 2024 18:29
Inactive
…ent-build into 17196-rs-detail-component-upgrade
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 7, 2024 18:08
Inactive
…ent-build into 17196-rs-detail-component-upgrade
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 8, 2024 20:04
Inactive
randimays
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
va-vfs-bot
temporarily deployed
to
master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade
March 11, 2024 17:46
Inactive
ataker
approved these changes
Mar 12, 2024
…ent-build into 17196-rs-detail-component-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Update components to use V3 for Resources and Support Detail page template.
Related issue(s)
department-of-veterans-affairs/va.gov-cms#17196
Testing done
Tested locally and in review instance
/resources/how-to-use-your-logingov-or-idme-account-to-access-my-healthevet/
/resources/in-state-tuition-rates-under-the-veterans-choice-act/
/resources/choosing-between-urgent-and-emergency-care/
Screenshots
What areas of the site does it impact?
Resources and Support Detail pages