Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17196 R&S Detail Page component upgrade to V3 #1934

Merged
merged 17 commits into from
Mar 12, 2024

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Feb 28, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Update components to use V3 for Resources and Support Detail page template.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#17196

Testing done

Tested locally and in review instance
/resources/how-to-use-your-logingov-or-idme-account-to-access-my-healthevet/
/resources/in-state-tuition-rates-under-the-veterans-choice-act/
/resources/choosing-between-urgent-and-emergency-care/

Screenshots

Choosing_Between_Urgent_And_Emergency_Care___Veterans_Affairs

Choosing_Between_Urgent_And_Emergency_Care___Veterans_Affairs

Choosing_Between_Urgent_And_Emergency_Care___Veterans_Affairs

Choosing_Between_Urgent_And_Emergency_Care___Veterans_Affairs

What areas of the site does it impact?

Resources and Support Detail pages

@chriskim2311 chriskim2311 requested review from a team as code owners February 28, 2024 19:06
Chris Kim added 2 commits February 28, 2024 11:35
…ment-of-veterans-affairs/content-build into 17196-rs-detail-component-upgrade
@chriskim2311 chriskim2311 changed the title 17196 rs detail component upgrade VACMS-17196 R&S Detail Page component upgrade to V3 Feb 28, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade February 28, 2024 20:21 Inactive
@Andrew565
Copy link
Contributor

PR has failing required tests, opting not to review at this time. - Tier 2/FE COP

@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade March 4, 2024 21:36 Inactive
…ent-build into 17196-rs-detail-component-upgrade
@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade March 5, 2024 18:56 Inactive
…ent-build into 17196-rs-detail-component-upgrade
@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade March 6, 2024 18:29 Inactive
…ent-build into 17196-rs-detail-component-upgrade
@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade March 7, 2024 18:08 Inactive
…ent-build into 17196-rs-detail-component-upgrade
@va-vfs-bot va-vfs-bot temporarily deployed to master/17196-rs-detail-component-upgrade/17196-rs-detail-component-upgrade March 8, 2024 20:04 Inactive
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ent-build into 17196-rs-detail-component-upgrade
@chriskim2311 chriskim2311 merged commit 7e873de into main Mar 12, 2024
22 checks passed
@chriskim2311 chriskim2311 deleted the 17196-rs-detail-component-upgrade branch March 12, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants