-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core release v39.0.0 + va-memorable-date: remove non-USWDS version #1116
Conversation
:host(:not([uswds='false'])) { | ||
:host { | ||
display: block; | ||
font-family: var(--font-source-sans); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The va-date
stylesheet was being imported previously for the v1 variation but there was still a few styles that the USWDS variation was relying on. We did not need the entire stylesheet though.
So I have removed that import @import '../va-date/va-date.css';
and instead added the relevant styles from there like these here.
We are going to have a lot of conflicts with our Formation base font size PR as we do these non-USWDS deprecations so after this is merged, I will make sure to go and resolve those conflicts there. |
@jamigibbs do we know if there are any v1 versions still in use on vets-website? |
Great question. I could not find any instances and confirmed in the component usage report too: https://docs.google.com/spreadsheets/d/1IKi_kNSQtasTb3hHbcKbhHLv7BCYCmRqsUtaRPcrtG8/edit#gid=299423802 |
Chromatic
https://2660-mem-date-v1-remove--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
This will remove the non-USWDS version of
va-memorable-date
. Only the USWDS variation will be available now.Closes department-of-veterans-affairs/vets-design-system-documentation#2660
QA Checklist
Screenshots
Acceptance criteria
Definition of done