Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core release v39.0.0 + va-memorable-date: remove non-USWDS version #1116

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Apr 11, 2024

Chromatic

https://2660-mem-date-v1-remove--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

This will remove the non-USWDS version of va-memorable-date. Only the USWDS variation will be available now.

Closes department-of-veterans-affairs/vets-design-system-documentation#2660

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@jamigibbs jamigibbs added the major Major change in semantic versioning label Apr 11, 2024
@jamigibbs jamigibbs changed the title va-memorable-date: remove original version va-memorable-date: remove non-USWDS version Apr 12, 2024
:host(:not([uswds='false'])) {
:host {
display: block;
font-family: var(--font-source-sans);
Copy link
Contributor Author

@jamigibbs jamigibbs Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The va-date stylesheet was being imported previously for the v1 variation but there was still a few styles that the USWDS variation was relying on. We did not need the entire stylesheet though.

So I have removed that import @import '../va-date/va-date.css'; and instead added the relevant styles from there like these here.

@jamigibbs
Copy link
Contributor Author

We are going to have a lot of conflicts with our Formation base font size PR as we do these non-USWDS deprecations so after this is merged, I will make sure to go and resolve those conflicts there.

@jamigibbs jamigibbs marked this pull request as ready for review April 12, 2024 15:40
@jamigibbs jamigibbs requested a review from a team as a code owner April 12, 2024 15:40
@powellkerry
Copy link
Contributor

@jamigibbs do we know if there are any v1 versions still in use on vets-website?

@jamigibbs
Copy link
Contributor Author

@jamigibbs do we know if there are any v1 versions still in use on vets-website?

Great question. I could not find any instances and confirmed in the component usage report too: https://docs.google.com/spreadsheets/d/1IKi_kNSQtasTb3hHbcKbhHLv7BCYCmRqsUtaRPcrtG8/edit#gid=299423802

@jamigibbs jamigibbs changed the title va-memorable-date: remove non-USWDS version Core release v39.0.0 + va-memorable-date: remove non-USWDS version Apr 16, 2024
@jamigibbs jamigibbs merged commit 32b2d44 into main Apr 16, 2024
10 checks passed
@jamigibbs jamigibbs deleted the 2660-mem-date-v1-remove branch April 16, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove V1 Memorable Date from Component Library and Storybook
4 participants