-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments for Formation base font-size change #1096
Merged
Merged
Changes from 9 commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
7cc0352
update accordion and breadcrumb for formation base font-size change
powellkerry de37b51
Fix heading sizes in elements.scss due to root font-size change
powellkerry 41f0ec5
fix: v1 button and icon font size
harshil1793 5cdd6a3
update package.json web-component from workspace
harshil1793 7f78b5e
remove formation-overrides file and make adjustments to components
powellkerry e7ff890
remove formation-overrides file and make adjustments to components
powellkerry 8221f8c
Update formation version, remove rc-* versions of packages
powellkerry 46f1e12
merge main, minor updates
powellkerry 46f7865
Fix e2e test
powellkerry 051579e
Fix inline storybook styles for segmented-progress-bar, match styles …
powellkerry 8003984
revert for local change that should not have been committed
powellkerry 7b9ea85
fix: v1 component rem correction
harshil1793 df58b45
fix: v1 components rem correction
harshil1793 d60ae32
Merge branch 'main' into 66753-formation-typography
jamigibbs a23fc16
v1 alert and promo-banner fix
harshil1793 bcfb8f2
Merge branch 'main' into 66753-formation-typography
jamigibbs 933d9bd
Update va-table for base font adjustment
powellkerry f586b5f
Update TextArea with formation font-size changes
nickjg231 dfabf90
Update NumberInput and additional TextInput styles with formation fon…
nickjg231 e387ada
Fix error font-size and legend max-width on checkbox group
powellkerry 3345778
v1 link component fixes
harshil1793 494082b
Merge branch 'main' into 66753-formation-typography
powellkerry ff5dd3a
v1 Alert rem padding fix
harshil1793 807e6bd
Fix mobile table styles
powellkerry f243328
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry 4da1f4c
Fix mobile table caption padding rem value
powellkerry 788479c
Try to get chromatic to take new screenshots for va-table
powellkerry 0ea72f0
revert storybook change for va-table, update from main
powellkerry 021afa1
Update va-privacy-agreement with typography changes
nickjg231 39cc570
update to require at least one label instead of exactly one
powellkerry 41aa74a
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry b082a5c
add empty div to va-text-input story to get chromatic to update
powellkerry c794e59
Fixes for pagination typopgraphy and spacing
powellkerry 74379b9
temp change for va-table stories
powellkerry c4f39f5
refresh va-pagination story snapshot
powellkerry 2658c75
force chromatic refresh
powellkerry 837da8e
Fix v1 segmented-progress-bar paddding in story
powellkerry ea56dac
Update formation to 11.0.1
powellkerry 0bd1267
updates for v1 accordion item spacing
powellkerry 3c0b566
Merge branch 'main' into 66753-formation-typography
powellkerry 17079eb
fix for va-statement-of-truth icon font-size
powellkerry 69eb7ab
Additional va-checkbox typography changes
nickjg231 5b04328
Fix text-input border width
powellkerry 04c026a
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry 979aacf
Convert missing rem values found during a global search
powellkerry 4862ffb
merge main
powellkerry ad14039
convert rev value in global/main.css and remove rem-override function…
powellkerry 407c91a
Merge branch 'main' into 66753-formation-typography
powellkerry afe7474
Merge branch 'main' into 66753-formation-typography
powellkerry 4b00d2c
convert rem values in html and tsx files
powellkerry ac47ef8
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry e32760e
Merge branch 'main' into 66753-formation-typography
powellkerry 7d19649
Fix e2e test
powellkerry 6d59a55
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry 93fd96c
remove _functions.scss file
powellkerry 988a0a4
add beta version numbers
powellkerry 42c35a5
update package.json files with beta releases and rebuild
powellkerry 9107ec5
Merge branch 'main' into 66753-formation-typography
jamigibbs 65ba4c6
remove formation override import from memorable-date
jamigibbs dcbbaa4
add formation override style back into component
jamigibbs 5f32aeb
fix memorable date day and year field widths
powellkerry 48b7f90
try adjusting chromatic.yml to remove onlyChanged
powellkerry ff59718
adjust month select width in memorable date
powellkerry f731fe1
merge main
powellkerry b6fd6d9
Merge branch 'main' into 66753-formation-typography
powellkerry a69df11
Merge branch 'main' into 66753-formation-typography
powellkerry 813acac
merge main
powellkerry e704862
merge main
powellkerry 64e3439
merge main, remove beta versions
powellkerry ddfcee4
fix react-components version number
powellkerry 5225901
update yarn.lock
powellkerry 7683ec5
Fix merge issues where removed code was re-added
powellkerry 09d8604
Merge branch 'main' into 66753-formation-typography
powellkerry 6e73f82
re-add memorable date changes
powellkerry b37a07f
Merge branch '66753-formation-typography' of https://github.com/depar…
powellkerry a7afbcf
Merge branch 'main' into 66753-formation-typography
jamigibbs c5ba26c
remove storybook file to match main
jamigibbs 9413ed5
convert heading rems in _va.scss and add box-sizing to process-list a…
powellkerry 0b734ff
fix typo in comment
powellkerry 21a6f64
Merge branch 'main' into 66753-formation-typography
powellkerry File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,2 @@ | ||
@forward 'settings'; | ||
@use 'usa-icon/src/styles/_usa-icon.scss'; | ||
|
||
@import '../../global/formation_overrides'; | ||
@use 'usa-icon/src/styles/_usa-icon.scss'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why this color needed to be removed? Is it cleanup from a previous tokens ticket we had been working on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes its cleanup, the build was failing because this variable didn't exist in USWDS. It needed to be "uswds-system-color-red-cool-vivid-10"