Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core for release v37.2.0 #1076

Merged
merged 1 commit into from Mar 6, 2024
Merged

Update core for release v37.2.0 #1076

merged 1 commit into from Mar 6, 2024

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Mar 6, 2024 •
edited by github-actions bot

Chromatic

https://core-release-v37.2.0--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Closes

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@jamigibbs jamigibbs added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Mar 6, 2024
@jamigibbs jamigibbs requested a review from a team as a code owner March 6, 2024 16:04
@jamigibbs jamigibbs merged commit dc4e43a into main Mar 6, 2024
10 checks passed
@jamigibbs jamigibbs deleted the core-release-v37.2.0 branch March 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew565 Andrew565 Andrew565 approved these changes

@micahchiang micahchiang micahchiang approved these changes

Assignees
No one assigned
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamigibbs @Andrew565 @micahchiang