Added restriction on the max number of retries are allowed #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic66209a3e4879a0143f298e608251cfb145bad80
add slb vserver group support
Change-Id: Id4853c7f15da42798708e004916c22b702825b54
2. Various enhancements and bug fixings
Moved role test to a separate package: role_test
This reverts commit 4dc107c.
Revert "Moved role test to a separate package: role_test"
2. list policies for roles 3. added corresponding unit tests
1. added support for attaching/detaching policies to/from roles
Added Ram Role support
Added STS support with unit tests
update ecsendpoint
Change-Id: Id7b6a642d9570af6ebbdab76b85de484efa533c1
2. Removed config file, instead, use environment variables to unit test
1. Set your AccessKeyId and AccessKeySecret in env simply use the command below: "AccessKeyId=YourAccessKeyId AccessKeySecret=YourAccessKeySecret go test" 2. Replace "MY_ACCESS_KEY_ID" & "MY_ACCESS_KEY_SECRET" with your own access key & secret and run "go test"
Get Bucket Info API support to oss
As the requests to Aliyun is so fast so that, without this restriction, if the request fails, it will retry 25 times in no more than 5 seconds. This is not too many. Please be aware that: The machine launches those requests is outside of Aliyun. It is expected to have more reties inside Aliyun. 2. Propose to change the "Min" value from 5 to 2, and change Total from 5 seconds to 3 seconds. I think this is more reasonable
|
I hesitate to accept this change, you can control the max retry with the total duration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the requests to Aliyun is so fast so that, without this restriction, if the request fails, it will retry 25 times in no more than 5 seconds. This is just too many.
Please be aware that:
The machine launches those requests is outside of Aliyun. It is expected to have more reties inside Aliyun.