fix(ext/http): don't create abort signal during request abort #23581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Apr 27, 2024
| @@ -592,8 +592,8 @@ const signalAbortError = new DOMException( | |||
| ); | |||
| ObjectFreeze(signalAbortError); | |||
|
|
|||
| function abortRequest(request) { | |||
| if (request[_signal]) { | |||
| function abortRequest(request, createNew = false) { | |||
There was a problem hiding this comment.
Unfortunately this won't work either. Most likely we'll need to set some sort of semaphore in the signal cache to state that any signal created here needs to be aborted on creation.
Something like if (request[_signalCache] === undefined) { request[_signalCache] = false } else { request[_signalCache][signalAbort](signalAbortError); }. In the signal getter, we should check request[_signalCache] === false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request[_signal]will always create a new signal if there isn't one. It seems this check should use_signalCacheinstead? cc @mmastrac