feat: upgrade Reqwest to 0.12 [WIP] #23542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
mmastrac
force-pushed
the
reqwest_update
branch
2 times, most recently
from
dd27eb2
to
4ba9036
Compare
mmastrac
force-pushed
the
reqwest_update
branch
from
6d71430
to
adae0c0
Compare
magurotuna
reviewed
May 5, 2024
| @@ -113,12 +113,12 @@ fs3 = "0.5.0" | |||
| futures = "0.3.21" | |||
| glob = "0.3.1" | |||
| h2 = "0.4.4" | |||
| http = "1.0" | |||
| http = "1.1" | |||
| http-body-util = "0.1" | |||
| http_v02 = { package = "http", version = "0.2.9" } | |||
| httparse = "1.8.0" | |||
| hyper = { version = "=1.1.0", features = ["full"] } | |||
There was a problem hiding this comment.
Quick question: would it be possible to bump hyper version to 1.3? Because reqwest has started to depend on hyper v1 since 0.12, and hyper 1.3 has my patch included which sets the initial number of concurrent send streams to a reasonable default value, upgrading hyper to v1.3 could also resolve #21789 too.
There was a problem hiding this comment.
Yes, we definitely can. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on TLS and deno_kv issues: