FUTURE: remove import assertions support for JavaScript #23541
Merged
+43
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petamoriken
force-pushed
the
feat/deny-import-assertions-with-deno-future-flag
branch
from
b14329e
to
6b636a5
Compare
bartlomieju
reviewed
Apr 24, 2024
petamoriken
force-pushed
the
feat/deny-import-assertions-with-deno-future-flag
branch
from
6b636a5
to
f39ec24
Compare
petamoriken
force-pushed
the
feat/deny-import-assertions-with-deno-future-flag
branch
from
f39ec24
to
a23a992
Compare
petamoriken
force-pushed
the
feat/deny-import-assertions-with-deno-future-flag
branch
from
a23a992
to
e330a91
Compare
petamoriken
force-pushed
the
feat/deny-import-assertions-with-deno-future-flag
branch
from
e330a91
to
830b68b
Compare
petamoriken
changed the title
bartlomieju
reviewed
Apr 29, 2024
| _ => { | ||
| if *DENO_FUTURE { | ||
| // deno_ast removes TypeScript `assert` keywords, so this flag only affects JavaScript | ||
| // TODO(petamoriken): Need to check TypeScript `assert` keywords in deno_ast |
There was a problem hiding this comment.
Do you think we should address this one before landing the PR?
There was a problem hiding this comment.
Yes, I think so. It would be better to work on a separate PR for TypeScript, since it is likely that the error will be displayed on the deno_ast side (swc-project/swc#8893 (comment)), rather than using this flag.
There was a problem hiding this comment.
Let me talk with @dsherret about this first 👍
There was a problem hiding this comment.
I think maybe we should just not worry about it for now? It would be a lot of work and supporting it can make more code just keep working for the time being.
petamoriken
deleted the
feat/deny-import-assertions-with-deno-future-flag
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #17944, swc-project/swc#8893
TypeScript removes the
assertkeywords in the transpile, so this PR only works for JavaScript files