Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): read(0) before destroying http2stream #23505

Merged
merged 3 commits into from Apr 30, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Apr 23, 2024

This fix enables grpc hello world client example to work.
TODO:

  • test

Run the following commands to test it:

git clone https://github.com/satyarohith/grpc-node && cd grpc-node && git checkout es_examples && cd examples
npm install
node helloworld/dynamic_codegen/greeter_server.js & denod run -A helloworld/dynamic_codegen/greete
r_client.js

denod is debug build of this patch

Towards #23246 #3326

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test is important here...

@satyarohith satyarohith changed the title fix(ext/node): read(0) before destroying http2stream [WIP] fix(ext/node): read(0) before destroying http2stream Apr 23, 2024
@satyarohith
Copy link
Member Author

satyarohith commented Apr 29, 2024

a test is important here...

It's difficult to get to a reproducible small unit test so I wrote a smoke test instead.

@satyarohith satyarohith changed the title [WIP] fix(ext/node): read(0) before destroying http2stream fix(ext/node): read(0) before destroying http2stream Apr 29, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed offline, Satya added tests in npm_smoke_tests

@satyarohith satyarohith merged commit 8503311 into main Apr 30, 2024
17 checks passed
@satyarohith satyarohith deleted the satya/fix_grpc_hello_world branch April 30, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants