Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): panic with deno coverage #23353

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

0xIchigo
Copy link
Contributor

This PR directly addresses the issue raised in #23282 where Deno panics if deno coverage is called with --include regex that returns no matches.

I've opted not to change the return value of collect_summary for simplicity and return an empty HashMap instead

@dsherret dsherret changed the title fix(cli) Fix panic with deno coverage fix(cli): panic with deno coverage Apr 13, 2024
@bartlomieju
Copy link
Member

Thanks for the PR, could you please add a test case that exercises this change? You can add an itest! check in tests/integration/coverage_tests.rs

@bartlomieju bartlomieju added this to the 1.44 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants