Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsr support #409

Merged
merged 16 commits into from Mar 23, 2024
Merged

jsr support #409

merged 16 commits into from Mar 23, 2024

Conversation

williamhorning
Copy link
Contributor

@williamhorning williamhorning commented Mar 23, 2024

this pr closes #408 and closes #404 by adding support for publishing to jsr and cleaning up stuff in the codebase

image

Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
@williamhorning
Copy link
Contributor Author

whoops it looks like i forgot to add an ignore directive for the any type, will fix

Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
@williamhorning williamhorning marked this pull request as ready for review March 23, 2024 03:31
Signed-off-by: Jersey <wgyt735yt@gmail.com>
@williamhorning
Copy link
Contributor Author

I've gone ahead and added some docs and everything should be good! With everything setup right on the JSR side, this gets a score of 94 and seems to work with existing stuff

@erfanium
Copy link
Member

@williamhorning Thanks!
can we still push releases to deno.land/x?

@williamhorning
Copy link
Contributor Author

@williamhorning Thanks! can we still push releases to deno.land/x?

yep! nothing stops you from publishing to both .land/x and jsr since deno supports jsr imports natively and has for a while

deno.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
mod.ts Show resolved Hide resolved
src/auth/base.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
Signed-off-by: Jersey <wgyt735yt@gmail.com>
@williamhorning
Copy link
Contributor Author

williamhorning commented Mar 23, 2024

fixed all the things mentioned above

oh and also, you'll need to get added to the @db scope on jsr to actually publish this under the @db/mongo name

@DjDeveloperr has admin over there so he might be able to sort things out

Copy link
Collaborator

@lucsoft lucsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@williamhorning
Copy link
Contributor Author

hey @erfanium could you take a look at this when you get the chance?

@lucsoft lucsoft merged commit 749d804 into denodrivers:main Mar 23, 2024
5 checks passed
@williamhorning williamhorning deleted the jsr-stuff branch March 23, 2024 23:46
@DjDeveloperr
Copy link
Member

I've invited @erfanium to @db scope on jsr.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish to jsr Avoid console.error (throw if needed)
4 participants