Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
@denford
denford committed Nov 5, 2015
1 parent 09675f7 commit d4ac5a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Expand Up @@ -257,4 +257,4 @@ We again refactor the `add` and `subtract` methods to take the number being adde
What is interesting in this final stage is that the final set of features, once again, cause us to re-think how the addition and subtraction work. We are left with a "working" calculator that is more sophisticated (real world), has less code, and supports more features. As we can see in the Stage3 [features file](https://github.com/denford/TuteCumber/blob/Stage3/features/multiple_operations.feature), we can start to specify all sorts of scenarios, including clearing the calculator mid-stream.
## Final Comments
One thing that makes it interesting (to me), and what I've tried to demonstrate here, is that we can see how the system being tested becomes more sophisticated as more features are added. I don't just mean that it becomes more complex, that more code is added, I mean that adding more feature specs forces (or at least strongly encourages) us to write a system that evolves quickly approximate what we think the final system should look like.
One thing that makes it interesting (to me), and what I've tried to demonstrate here, is that we can see how the system being tested becomes more sophisticated as more features are added. I don't just mean that it becomes more complex, that more code is added, I mean that adding more feature specs forces (or at least strongly encourages) us to write a system that evolves quickly to approximate what we think the final system should look like.

7 comments on commit d4ac5a8

@jharter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr. Denford. This tutorial does not seem to run on my Windows 7 machine. It runs on my Mac. When I try to run the "npm test", my installation of WebStorm loads this: #!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,,/,g')")

case uname in
CYGWIN) basedir=cygpath -w "$basedir";;
esac

if [ -x "$basedir/node" ]; then
"$basedir/node" "$basedir/../cucumber/bin/cucumber.js" "$@"
ret=$?
else
node "$basedir/../cucumber/bin/cucumber.js" "$@"
ret=$?
fi

exit $ret

It does not like this at all. About fifteen errors. Looks like it does not path names and quotes, etc. Like it won't run under window. What am I missing?

@mr
Copy link

@mr mr commented on d4ac5a8 Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful with those @ signs.

@denford
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jharter I've never run it on windows, and I don't actually have a windows environment to test it on. Having said that, I haven't updated this for a while and I wouldn't be surprised if there were issues due to updates in cucumberjs etc since I wrote it. I should go through and check it all works still. Having said that, I'd still struggle to test it out on Windows.

@denford
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jharter perhaps it's related to, or similar to, this: cucumber/cucumber-js#60 - as @jbpros wrote there:

Try running cucumber-js instead of cucumber.js

you'll see from the package.json that npm test runs cucumber.js which perhaps doesn't work on Windows

@jharter
Copy link

@jharter jharter commented on d4ac5a8 Jun 23, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jharter
Copy link

@jharter jharter commented on d4ac5a8 Jun 23, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jharter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbpros - Thought I should update these comments with jbpro's insight. Windows needs to run cucumber-js and not cucumber.js. Like he said, update the package.json file and the tutorial runs fine. I believe you do have to run this in a Bash session and not a Windows Console session. Thanks for everyone's help. There were three excellent responses to my question from this community in one day. Is that cool! Thanks.

Please sign in to comment.