Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add button addons #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add button addons #1104

wants to merge 1 commit into from

Conversation

ikenjoku
Copy link

No description provided.

ManAnRuck
ManAnRuck requested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@ManAnRuck ManAnRuck left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice when you can also reduce the 4 button stories to just one with the textColor, backgroundColor as selection fields :)

with this change (down) the linter should work :)

packages/mobile-ui/storybook/index.ts Outdated Show resolved Hide resolved
@ikenjoku ikenjoku force-pushed the 2020/sprint#5/add-button-addons branch from 0f10dd5 to 6b1cada Compare March 16, 2020 17:22
@ikenjoku ikenjoku force-pushed the 2020/sprint#5/add-button-addons branch from 6b1cada to 6c494bd Compare March 20, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManAnRuck ManAnRuck ManAnRuck requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Democracy
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikenjoku @ManAnRuck