fix: Update special chats icons even if they are blocked (#5509) #5540
Conversation
E.g. the multi-device synchronisation creates the "Saved Messages" chat as blocked, in this case the chat icon wasn't updated before and the user avatar was displayed instead.
iequidoo
force-pushed
the
iequidoo/update_saved_messages_icon
branch
from
96bee0c
to
e410119
Compare
|
thanks a lot for diving into this issue, @iequidoo!
was that a bug then? creating saved messages as "Blocked" or as "Contact Request" seems wrong - but i do not see in the code how that is fixed now - imu, the changes to but i am also sure not to have the full picture :) |
I think creating the self-chat as blocked isn't a bug, it's for making the chat hidden in the chatlist (if it hasn't yet existed or was deleted) -- see your initial commit 65f09c2. So, you're the author :) Anyway the self-chat gets unblocked when the user tries to look it up the first time. But if you e.g. try to forward some message, you wouldn't see the self-chat if you didn't use it before, not sure if this is on purpose. |
|
thanks for the detailed explanations - and yeah, i forgot that the saved-messages chat needs to be created hidden for $reasons :) and that it was even me :) |
…d when applicable `ChatId::lookup_by_contact()` returns `None` for blocked chats, so it should be only used if we need to filter out blocked chats, e.g. when building a chatlist.
iequidoo
force-pushed
the
iequidoo/update_saved_messages_icon
branch
from
e410119
to
17e3694
Compare
E.g. the multi-device synchronisation creates the "Saved Messages" chat as blocked, in this case the chat icon wasn't updated before and the user avatar was displayed instead.
Fix #5509
EDIT: In the most other places
ChatIdBlocked's method must be used as well, fixed them too.