Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdio jsonrpc server npm package #5332

Merged
merged 48 commits into from May 11, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Mar 10, 2024

  • figgure out how to build the packages (that it installs native optional package automatically)
  • Make the gluecode
    • expose both the lowerlevel api that desktop uses (send objects and receive objects, getting path of rpc-server is enough)
    • and the higher level api needed for bots (jsonrpc client)
    • typescript types
    • automatically pick the right binary from npm or allow getting it from env var, or give out an error (throw error)
    • find out how to dev locally (use local built core in dc desktop) - there is the question of how to link the typescript client and the task to add a search in the cargo target folder for a debug build or a different way, find out some good flow that we can use and document for dc desktop + locally built core development
  • build the packages in ci
  • fix that deltachat-rpc-server is not executable

postponed:

  • publish from ci
    • add key/token to deploy to npm

Closes #4694

Related prs

@Simon-Laux Simon-Laux force-pushed the simon/stdio-jsonrpc-server-npm-package branch from 7f6567f to b5fbdda Compare May 3, 2024 15:12
@Simon-Laux Simon-Laux marked this pull request as ready for review May 10, 2024 01:25
@Simon-Laux Simon-Laux changed the title simon/stdio jsonrpc server npm package stdio jsonrpc server npm package May 10, 2024
@link2xt
Copy link
Collaborator

link2xt commented May 11, 2024

I removed rustup as a dependency for printing targets. cargo already reports a nice error suggesting rustc --print target-list when the target is not available.

@Simon-Laux Simon-Laux merged commit c375c03 into main May 11, 2024
28 of 29 checks passed
@Simon-Laux Simon-Laux deleted the simon/stdio-jsonrpc-server-npm-package branch May 11, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Package deltachat-rpc-server to npm
2 participants