feat: Case-insensitive search for non-ASCII messages (#5052) #5321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite search with
LIKE
is case-insensitive only for ASCII chars. To make it case-insensitive for all messages, create a new columnmsgs.txt_normalized
defaulting toNULL
(so we do not bump up the database size in a migration) and storing lowercased/normalized text there when the row is created/updated. When doing a search, search overIFNULL(txt_normalized, txt)
.Close #5052