Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting selfavatar before configure changes the "Saved Messages" chat icon to avatar image #5509

Closed
adzialocha opened this issue Apr 29, 2024 · 3 comments · Fixed by #5540
Closed
Assignees
Labels
bug Something is not working

Comments

@adzialocha
Copy link
Member

  1. Call setConfig with selfavatar
  2. Call configure
  3. Saved Message Chat has default icon
  • Actual behavior:
  1. Call setConfig with selfavatar
  2. Call configure
  3. Saved Message Chat has avatar image
  • Screenshots:
    2024-04-29-142550_861x520_scrot

Maybe it's actually not a "bug" but a "feature", I'll report it here anyhow just in case.

Related discussion in Desktop: deltachat/deltachat-desktop#3773 (comment)

@adbenitez
Copy link
Member

it is actually really easy to reproduce:

  1. Delete "Saved Messages"
  2. set an avatar if you don't have one already
  3. start a new chat with yourself so "saved messages" is recreated
  4. now it has your avatar

Image

@iequidoo iequidoo assigned iequidoo and unassigned iequidoo May 3, 2024
@r10s
Copy link
Member

r10s commented May 6, 2024

  1. set an avatar if you don't have one already

for me, that @adbenitez's step is not quite correct:

the bug happens for me only when i really set an avatar in step 2. - without, on further tries, the saved-messages-icon is displayed correctly

@iequidoo i cannot make full sense of it - but may it be related to an sync item somehow? after setting an avatar, there is an sync item containing the self-avatar, which is then used instead of the saved-messages-icon.

without setting an avatar, deletion and recreation of the saved-messages-chat always uses the correct saved-messages-icon - as there is no sync item

back to the initial issue - might be that a sync item is created even for unconfigured accounts (really?) - and then we might have a similar situation

i am not deep into these sync ongoings, though

@iequidoo iequidoo self-assigned this May 7, 2024
@iequidoo
Copy link
Collaborator

iequidoo commented May 7, 2024

@r10s, yes, it's caused by sync messages, i disabled them via environment and it stopped to reproduce.

iequidoo added a commit that referenced this issue May 7, 2024
E.g. the multi-device synchronisation creates the "Saved Messages" chat as blocked, in this case the
chat icon wasn't updated before and the user avatar was displayed instead.
iequidoo added a commit that referenced this issue May 7, 2024
E.g. the multi-device synchronisation creates the "Saved Messages" chat as blocked, in this case the
chat icon wasn't updated before and the user avatar was displayed instead.
iequidoo added a commit that referenced this issue May 11, 2024
E.g. the multi-device synchronisation creates the "Saved Messages" chat as blocked, in this case the
chat icon wasn't updated before and the user avatar was displayed instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
Development

Successfully merging a pull request may close this issue.

4 participants