feat(python): release GIL for common functions #2269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz101
requested review from
MrPowers,
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
github-actions
bot
added
binding/python
|
I'm excited for this. Thanks for working on it @franz101 ! Looking briefly it looks like the linter is sad. |
wjones127
reviewed
Mar 12, 2024
python/src/lib.rs
Outdated
| let (table, metrics) = rt()? | ||
| .block_on(cmd.into_future()) | ||
| .map_err(PythonError::from)?; | ||
| self._table.state = table.state; |
There was a problem hiding this comment.
Could we move updating the table state outside of the allow_threads call? this requires mutating self, which should be done while holding the GIL.
Same thing applies to other methods.
ion-elgreco
force-pushed
the
feature/release_gil_common_patterns
branch
from
36206bd
to
97967cb
Compare
|
For the cases when you need the GIL, could you also release it and re-acquire it when needed, if the fraction of time it's not needed is large? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by the previous request to release the GIL added to most common functions.
Related Issue(s)
#2234
If some function are not supported / should not be released or I forgot to add the function, happy to modify the PR