Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Smb share settings resource #158

Merged
merged 1 commit into from
May 24, 2024
Merged

Implement Smb share settings resource #158

merged 1 commit into from
May 24, 2024

Conversation

sapana05
Copy link
Contributor

Description

Implement SMB share setiings resource

ISSUE TYPE

  • Feature Pull Request

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@sapana05
Copy link
Contributor Author

smb_settings_resource

@sapana05
Copy link
Contributor Author

image

image

@sapana05 sapana05 force-pushed the smb-share-settings-resource branch from 7159a33 to 60048a6 Compare May 22, 2024 05:12
@sapana05 sapana05 requested a review from NavisJ May 22, 2024 06:00
@taohe1012
Copy link
Collaborator

hi @sapana05 ,please squash 2 commits to one, thanks

@sapana05 sapana05 force-pushed the smb-share-settings-resource branch 3 times, most recently from 066e81c to 20a1951 Compare May 22, 2024 20:00
@sapana05 sapana05 requested a review from taohe1012 May 22, 2024 20:05
@sapana05 sapana05 force-pushed the smb-share-settings-resource branch 2 times, most recently from 20a1951 to 05db8bf Compare May 23, 2024 05:51
@sapana05
Copy link
Contributor Author

run e2e test

@sapana05 sapana05 force-pushed the smb-share-settings-resource branch from 8f56add to dd96b03 Compare May 23, 2024 06:18
@sapana05 sapana05 force-pushed the smb-share-settings-resource branch from dd96b03 to 25a7445 Compare May 23, 2024 12:28
@sapana05
Copy link
Contributor Author

run e2e test

@sapana05
Copy link
Contributor Author

run e2e test

@sapana05 sapana05 merged commit 240afdb into main May 24, 2024
7 checks passed
@sapana05 sapana05 deleted the smb-share-settings-resource branch May 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taohe1012 taohe1012 taohe1012 approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

@NavisJ NavisJ Awaiting requested review from NavisJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sapana05 @taohe1012 @NavisJ