Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Storage pool enhancements #57

Merged
merged 14 commits into from
May 27, 2024

Conversation

trisha-dell
Copy link
Collaborator

Description

Adding support for parameters for Storage pool.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional testing
  • Unit testing

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 68.47291% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 90.36%. Comparing base (0df06dd) to head (c71e68b).
Report is 24 commits behind head on main.

Files Patch % Lines
plugins/modules/storagepool.py 66.04% 90 Missing and 38 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   91.71%   90.36%   -1.36%     
==========================================
  Files          49       49              
  Lines        6871     7078     +207     
  Branches      855      919      +64     
==========================================
+ Hits         6302     6396      +94     
- Misses        316      398      +82     
- Partials      253      284      +31     
Flag Coverage Δ
units 90.36% <68.47%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachin-apa
Copy link
Collaborator

run e2e

@sachin-apa sachin-apa merged commit 3d451c2 into main May 27, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants