Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT enahancement for MDM Cluster Module #53

Merged
merged 4 commits into from
May 27, 2024
Merged

UT enahancement for MDM Cluster Module #53

merged 4 commits into from
May 27, 2024

Conversation

felixs88
Copy link
Collaborator

@felixs88 felixs88 commented Apr 29, 2024 •
edited

Description

UT enhancement for MDM cluster module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@sachin-apa sachin-apa merged commit d95adda into dell:main May 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jennifer-John Jennifer-John Jennifer-John approved these changes

@sachin-apa sachin-apa sachin-apa approved these changes

@meenakshidembi691 meenakshidembi691 meenakshidembi691 approved these changes

@Bhavneet-Sharma Bhavneet-Sharma Bhavneet-Sharma approved these changes

@kuttattz kuttattz Awaiting requested review from kuttattz

@Pavan-Mudunuri Pavan-Mudunuri Awaiting requested review from Pavan-Mudunuri

@trisha-dell trisha-dell Awaiting requested review from trisha-dell trisha-dell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felixs88 @ansible-collections-svc @Jennifer-John @sachin-apa @meenakshidembi691 @Bhavneet-Sharma