Properly configure typescript dependencies #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
typescript-config
branch
6 times, most recently
from
0191d4b
to
5531809
Compare
A `yarn build` command from any of the packages will now correctly build the referenced packages. Also executing the build scripts in each of the packages in now handled by the `yarn workspaces run` command, instead of the custom command runner in `scripts/build.js`
koenpunt
force-pushed
the
typescript-config
branch
from
5531809
to
6fb21fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the project somehow is still active (we recently had to switch from the hosted version to a self-hosted one, because https://app.deliverybot.dev stopped working), but in the process of deploying Deliverybot to our own environment I did some optimizations in the project setup.
A
yarn buildcommand from any of the packages will now correctly build the referenced packages.Also executing the build scripts in each of the packages in now handled by the
yarn workspaces runcommand, instead of the custom command runner inscripts/build.js.