Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandrecurtelin
Copy link

Removed the preceding slash that was preventing GPSP to work properly.

Removed the preceding slash that was preventing GPSP to work properly.
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

@AGulev
Copy link
Contributor

AGulev commented Mar 19, 2021

with without this symbol it should be path to the string eg @string/app_id
this symbol makes it possible to put the value itself instead of the reference to the value in strings here

@britzl
Copy link
Contributor

britzl commented Mar 19, 2021

Hmm, this value has changed a few times. Most recent change:

https://github.com/defold/extension-gpgs/blame/master/gpgs/manifests/android/AndroidManifest.xml#L6

@SkaterDad GPGS is working as it is now right?

@AGulev good suggestion btw!

@AGulev
Copy link
Contributor

AGulev commented Mar 19, 2021

keeping this value in "@string/app_id" is the safest way I think, but isn't so convenient.
As I know if we wanna reat it as vulue we should have \ (with space)
or first symbol of the ID in unicode, like \u0039 for if the first symbol 9

@AGulev
Copy link
Contributor

AGulev commented Mar 19, 2021

otherwise parser is looking for @sting/ here

@SkaterDad
Copy link
Contributor

@britzl the current version works for me. I haven't tried building for a month or so, but the published game is fine.

@britzl
Copy link
Contributor

britzl commented Mar 27, 2021

So there are conflicting suggestions here. The PR suggests dropping the space while one user confirms that it works as it is. I do not know what is correct.

One option may be to change how GPGPS is initialized and let the user do it himself or do it from C (and read the config value from game.project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants