tf: improve finetune params to keep from user input

[iProzd]

Summary by CodeRabbit

• Refactor
  • Improved clarity in model parameter replacement functionality by removing outdated comments and unnecessary logic.

[coderabbitai]

Walkthrough

The update involves refining the function replace_model_params_with_pretrained_model within the finetune.py module. A previously commented-out TODO note and its related but unused logic, which concerned the retention of certain non-structural parameters, have been removed. This change simplifies the function by eliminating unnecessary comments and inactive code.

Changes

File Path	Change Summary
.../tf/utils/finetune.py	Removed a commented-out TODO and related unused logic.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iProzd]

I've checked for #3551 , there are several params that need discussed whether to keep from new input script (now we only keep trainable params and replace others with those in the pre-trained model):

• exclude_types from descriptor
• atom_ener from EnerFitting

Do we need to keep these params from user-defined fine-tuning input script? @njzjz @wanghan-iapcm If not, there's nothing to change for this issue.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (4b319a0) to head (69d0973).

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3750      +/-   ##
==========================================
- Coverage   82.23%   79.28%   -2.95%     
==========================================
  Files         513      513              
  Lines       47750    47749       -1     
  Branches     2980     2979       -1     
==========================================
- Hits        39265    37856    -1409     
- Misses       7574     8996    +1422     
+ Partials      911      897      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[njzjz]

Do we need to keep these params from user-defined fine-tuning input script?

Why not provide an option to users?