-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable TCH rule to move imports to TYPE_CHECKING #3602
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3602 +/- ##
===========================================
- Coverage 82.58% 63.52% -19.07%
===========================================
Files 515 171 -344
Lines 48796 20150 -28646
Branches 2982 2968 -14
===========================================
- Hits 40300 12800 -27500
+ Misses 7585 6896 -689
+ Partials 911 454 -457 ☔ View full report in Codecov by Sentry. |
@@ -179,19 +178,19 @@ | |||
def serialize(self) -> dict: | |||
raise NotImplementedError | |||
|
|||
def deserialize(cls) -> "EnergyFittingNetDirect": | |||
def deserialize(cls) -> EnergyFittingNetDirect: |
Check notice
Code scanning / CodeQL
First parameter of a method is not named 'self' Note
atomic: Literal[False] = False, | ||
) -> Tuple[np.ndarray, np.ndarray, np.ndarray]: ... | ||
) -> tuple[np.ndarray, np.ndarray, np.ndarray]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
*, | ||
atomic: Literal[True], | ||
) -> Tuple[np.ndarray, np.ndarray, np.ndarray, np.ndarray]: ... | ||
) -> tuple[np.ndarray, np.ndarray, np.ndarray, np.ndarray]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
This PR is not compatible with PyTorch. Closing. |
No description provided.