Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test of electronic_configuration_embedding if mendeleev is not installed #3755

Merged
merged 1 commit into from
May 7, 2024
Merged

test: skip test of electronic_configuration_embedding if mendeleev is not installed #3755

merged 1 commit into from
May 7, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm commented May 7, 2024 •
edited by coderabbitai bot

Summary by CodeRabbit

  • Chores

    • Updated the pre-commit hooks to a newer version for improved performance and bug fixes.

  • Tests

    • Enhanced test reliability by skipping certain tests if the required mendeleev module is not available.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz May 7, 2024 04:11
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 7, 2024 •
edited

Walkthrough

Walkthrough

The recent updates include two main changes. First, the ruff-pre-commit repository's version was updated from v0.4.2 to v0.4.3, enhancing the pre-commit hooks with possible bug fixes or improvements. Secondly, in the testing framework, a new condition checks for the presence of the mendeleev module in test_econf_embd.py. If absent, the test is skipped, ensuring the testing process is more robust and adaptable to different environments.

Changes

File Path Change Summary
.pre-commit-config.yaml Updated the ruff-pre-commit repository version from v0.4.2 to v0.4.3.
source/tests/.../test_econf_embd.py Added a conditional check for the mendeleev module. If not present, the test is skipped using the @unittest.skipIf decorator.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3d87e57 and aabbf5d.
Files selected for processing (2)
  • .pre-commit-config.yaml (1 hunks)
  • source/tests/common/test_econf_embd.py (1 hunks)
Files not reviewed due to errors (1)
  • source/tests/common/test_econf_embd.py (no review received)
Files skipped from review due to trivial changes (1)
  • .pre-commit-config.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Python label May 7, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 7, 2024
View reviewed changes
source/tests/common/test_econf_embd.py
@@ -6,7 +6,15 @@
make_econf_embedding,
)

try:
import mendeleev # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'mendeleev' is not used.
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (3d87e57) to head (aabbf5d).
Report is 1 commits behind head on devel.

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #3755   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files         513      513           
  Lines       47634    47634           
  Branches     2979     2979           
=======================================
  Hits        39186    39186           
  Misses       7537     7537           
  Partials      911      911

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue May 7, 2024
@wanghan-iapcm wanghan-iapcm linked an issue May 7, 2024 that may be closed by this pull request
tests.common.test_econf_embd.TestEConfEmbd.test_fe failed #3743
Open
Merged via the queue into deepmodeling:devel with commit df345ec May 7, 2024
60 checks passed
@wanghan-iapcm wanghan-iapcm deleted the fix-test-mendeleev branch May 7, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests.common.test_econf_embd.TestEConfEmbd.test_fe failed
2 participants
@wanghan-iapcm @njzjz