Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.common.test_econf_embd.TestEConfEmbd.test_fe failed #3743

Open
njzjz opened this issue May 6, 2024 · 3 comments · Fixed by #3755
Open

tests.common.test_econf_embd.TestEConfEmbd.test_fe failed #3743

njzjz opened this issue May 6, 2024 · 3 comments · Fixed by #3755
Assignees
Labels

Comments

@njzjz
Copy link
Member

njzjz commented May 6, 2024

―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― TestEConfEmbd.test_fe ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

self = <tests.common.test_econf_embd.TestEConfEmbd testMethod=test_fe>

    def test_fe(self):
>       res = make_econf_embedding(["Fe"], flatten=False)["Fe"]

common/test_econf_embd.py:12:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../../deepmd/utils/econf_embd.py:198: in make_econf_embedding
    ir = make_element_embedding_list_vec(ii)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

ename = 'Fe'

    def make_element_embedding_list_vec(
        ename: str,
    ) -> np.ndarray:
        """Compute the embedding of one element."""
        ret = make_empty_list_vec()
>       ele = element(ename)
E       NameError: name 'element' is not defined

../../deepmd/utils/econf_embd.py:183: NameError

 source/tests/common/test_econf_embd.py0% ▏

―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― TestEConfEmbd.test_fe_flatten ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

self = <tests.common.test_econf_embd.TestEConfEmbd testMethod=test_fe_flatten>

    def test_fe_flatten(self):
>       res = make_econf_embedding(["Fe"], flatten=True)["Fe"]

common/test_econf_embd.py:36:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../../deepmd/utils/econf_embd.py:198: in make_econf_embedding
    ir = make_element_embedding_list_vec(ii)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

ename = 'Fe'

    def make_element_embedding_list_vec(
        ename: str,
    ) -> np.ndarray:
        """Compute the embedding of one element."""
        ret = make_empty_list_vec()
>       ele = element(ename)
E       NameError: name 'element' is not defined

../../deepmd/utils/econf_embd.py:183: NameError

 source/tests/common/test_econf_embd.py0%
@njzjz njzjz added the bug label May 6, 2024
@njzjz
Copy link
Member Author

njzjz commented May 6, 2024

It happens when mendeleev is not installed.
(1) a user-friend message is required.
(2) skip the test?

@wanghan-iapcm
Copy link
Collaborator

I agree to skip test and print warning message when mendeleev is not installed.

@wanghan-iapcm
Copy link
Collaborator

I may contribute later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants