Update MyModelWrapper so that sklearn recognizes as a classifier.
#2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `MyModelWrapper` so that sklearn recognizes as a classifier.
|
|
noamzbr
approved these changes
Feb 22, 2024
noamzbr
reviewed
Feb 22, 2024
noamzbr
added
bug
and removed
feature
|
@chris-santiago thanks for catching and fixing this! |
|
@all-contributors add @chris-santiago for code |
|
I've put up a pull request to add @chris-santiago! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
MyModelWrapperso that sklearn recognizes as a classifier.Reference Issues/PRs
Fixes #2750
What does this implement/fix? Explain your changes.
Adds/sets the
_estimator_typeto"classifier"for theMyModelWrapperclass that wraps classification models within theDeepcheckScorerclass. This ensures that scikit-learn treats wrapper as a classifier and does not raise aValueErrorwhen calling scorer withpredict_probamethod.Any other comments?
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst