textinput: fix placeholder size #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (placeholder == undefined) | ||
| return false; | ||
|
|
||
| if (placeholder.lenght) |
There was a problem hiding this comment.
typo here. Should be length.
| @@ -24,7 +24,15 @@ const TextInput = ({ | |||
| useMountEffect(() => { | |||
| autoFocus && input && input.current.focus(); | |||
| }); | |||
|
|
|||
|
|
|||
| const isPlaceholder = (placeholder) => { | |||
There was a problem hiding this comment.
The name of this function should be hasPlaceholder. Also, if placeholder === "" your code will return undefined.
| <input | ||
| id={id} | ||
| ref={input} | ||
| placeholder={placeholder || " "} | ||
| size={isPlaceholder(placeholder) ? placeholder.length : undefined} |
There was a problem hiding this comment.
The idea is nice and it fixes the issue you linked. But we don't want all TextInputs with placeholders working like this.
| <input | ||
| id={id} | ||
| ref={input} | ||
| placeholder={placeholder || " "} | ||
| size={isPlaceholder(placeholder) ? placeholder.length : undefined} | ||
| className={classNames(styles.textinput, inputClassNames)} | ||
| type={type} | ||
| {...props} |
There was a problem hiding this comment.
We spread the props object here so people can customize TextInputs outside the pi-ui package. That means you can just pass a size prop from Decrediton and pi-ui will just "forward" it to the HTML input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix the problem in this issue