Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for fr v1.8.0 #3895

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JaseurPattu
Copy link

No description provided.

@xaur xaur mentioned this pull request Jul 31, 2023
Copy link

@nnnko56 nnnko56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Opinion
After reviewing all the submitted files of this PR, I recommend it to be merged in the code.

There are some errors and corrections needed and there's place for improvement in multiple instances, but the volume of work in this PR is massive and canot be dismissed. In addition, it will be a lot simpler to make smaller changes afterwards.

Review Format:
With my review there is close to 300 line comments with fixes, suggestions, or remarks. The vast majority are minor edits (punctuation, grammar, typos) and could be tackled later on in a follow-up PR.

All my comments and suggestions can be tracked with this simple pseudo-code format in the comments:

[new word] <= suggested added word or letter
{removed word} <= suggested for removal
< old | new > <= suggested for replacement

For example :

This is a [bigger] sentence => This is a bigger sentence
This is a {paragraph} sentence => This is a sentence
This is < a big | an adequate > sentence. => This is an adequate sentence

Before Next Release:
There is however some errors that I feel should at least be corrected before the next release. For clarity I will relist them here, and you can refer to the corresponding line comment for details and a suitable replacement if needed:

app/i18n/docs/fr/Tutorials/DecredIntoPage02.md

  • The translation says that PoS can "replace" PoW, which is not accurate. PoS can Override PoW Blocks but PoS cannot create blocks.

app/i18n/docs/fr/Tutorials/DecredIntoPage01.md and more (search comments and pr for "Jeton")

  • Decred is refered to as Tokens instead of money. In most occasion "jeton" ou "jetons" , should be replaced by "monnaie" see line comments

app/i18n/translations/fr.json

1- "export.transactions.fields.credits" :
The proposed translation of "transaction outputs" would means "outgoing transactions", which for addresses in a wallet technically is the opposite of what is intended.

2- "export.transactions.fields.debits"
The proposed translation of "transaction inputs" would means "incoming transactions", which for addresses in a wallet technically is the opposite of what is intended

3- "mixer.start.running":
is a translation error, could be a copy/paste error but it says to stop the mixer in order to start the mixer. ( should be: in order to buy a ticket)

Standardization of terms:
Outside of the these errors there are certain words that reoccur often in our texts and that should be standardized to make things easier to read and to use industry recognized terms. In some case it's extremely hard because there is "no" good translation, but we should at least attempt to make our docs consistent with how we use them. Ideally these should be discussed before the next PR. Somme of these are tagged with line comments and some are not. Also, only submitted edits from the pr have been reviewed and not the unchanged content of these files. Instances can be found by searching the words.

PdT/PoW PdE/PoS
These acronyms and the corresponding terms are used multiple times in the translation. But the format vary a lot. sometimes the English acronym is in parenthesis , or there is a /, or it's not there or Only the English acronym is used. Ideally we should always write it the same way.
Maybe :

  • PdT (PoW)
  • PdE (PoS)
    We could reserve the / for the hybrid nature of Decred PdT/PdE
    And should we keep the acronym along when using the longer name ?
  • Preuve de Travail (PdT)
  • Preuve d'Enjeu (PdE)

Stake:

Stake is used as-is without translation in multiple instances but we do have an accurate translation for Proof-Of-Stake (Preuve d'enjeu). In order to be consistent, the stake could be something like "l'enjeu" And we could decide to always include the English word for clarity : - Enjeu (stake)

staking
Staking is the worst of all. There is no "good" translation for the action of putting in stake in French except maybe "parier" which means gamble and is inaccurate in this context. I would suggest between the following:

  • Participation à la preuve d'enjeu (staking)
  • Mise en enjeu (staking)
  • Enjeu (staking)
  • Participation à l'enjeu (staking)

Stakeholders
Similar to the previous ones, maybe :

  • Détendeurs d'enjeu
  • Participants à l'enjeu
  • Participant à la preuve d'enjeu

automatisé
In almost all occurrences, I feel like "automatique" should be used

périphérique
For Trezor and other hardware wallets, the more accurate term would be "dispositif". Because "Périphérique"/peripheral is usually a device that extends the functions of a computer and offer no function by itself.

paramétrage
The usual words for software settings in French is "Configuration" (general), paramètre ( one setting), paramètres (a group of settings)

sécurisé
Sécurisé is not the best choice of word. It tries to replicate the English word "secure" but means something that has been made secure (was not previously). In french we can simply say "sûr" or "sécuritaire" which means it simply "IS" secure.

Additional remarks
I have noticed a few entries in the fr.json files that have no corresponding entries in the source English file. Unused entries have no impact on the user experience, but a little clean-up should be made to remove unused entries.

Finally I'm sure it is known already but the English source needs updating after 1/89/10. For now translation files "correctly" mirror the outdated values from the source English file.


Démarrez toujours vos portefeuilles externes en premier et arrêter les en dernier.

Pendant un échange, si vous ou votre contrepartie n'agissez pas, aura pour conséquence de révoquer la rencontre pour échange après une période définie. Si vous subissez une révocation, gardez votre logiciel DEX et les portefeuilles démarrés jusqu'au remboursement complet. Il peut se passer 20 heures dépendant si vous étiez le faiseur (maker) ou le preneur (taker) dans l'échange.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - Pendant un échange, si vous ou votre contrepartie n'agissez pas, [cela] aura pour conséquence de révoquer < la rencontre | l'association> pour échange après une période définie.

2- votre logiciel DEX et les portefeuilles < démarrés | ouverts >

3- Il peut se passer 20 heures [avant le remboursement] < dépendant si | selon que > vous étiez le faiseur (maker) ou le preneur (taker) dans l'échange.


Pendant un échange, si vous ou votre contrepartie n'agissez pas, aura pour conséquence de révoquer la rencontre pour échange après une période définie. Si vous subissez une révocation, gardez votre logiciel DEX et les portefeuilles démarrés jusqu'au remboursement complet. Il peut se passer 20 heures dépendant si vous étiez le faiseur (maker) ou le preneur (taker) dans l'échange.

Si vous avez besoin de support, veuillez-vous rendre sur [la chat room #dex sur Matrix](https://matrix.to/#/!mlRZqBtfWHrcmgdTWB:decred.org?via=decred.org&via=matrix.org&via=planetdecred.org).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- rendre sur [ < la chat room | le canal > #dex sur Matrix]


Ce système hybride limite les faiblesses que les systèmes PdE/PoS et PdT/PoW ont individuellement. De plus il constitue un pilier essentiel pour la **gouvernance intelligente** du projet.

La participation généralisée au **staking (PdE/PoS)** et au **minage (PdT/PoW)** aide à protéger la neutralité du réseau et récompense les participants avec des nouveaux DCR créé depuis la récompense de bloc.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- participants avec des nouveaux DCR créé[s] < depuis | via > la récompense de bloc.


**Le portefeuille est un outil interagissant avec la blockchain et qui utilise Decred en tant que devise**. Vous pouvez l'utiliser pour envoyer ou recevoir des fonds en DCR, mais aussi en tant que registre personnel pour enregistrer vos transactions, ou encore pour participer au staking (PdE/PoS).

Les portefeuilles sont générés de façon déterministe par une graine (seed). La graine mnémonique est constituée d'une liste de **33 mots** que vous pouvez facilement écrire sur un papier pour la conserver.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- sur un papier < pour | afin de > la conserver.


**La graine est une clé principale** contenant toutes les informations nécessaires pour restaurer à tout moment votre portefeuille, et ceci même si la phrase secrète utilisée pour le chiffrage de votre portefeuille a été oubliée ou détruite. La graine peut aussi être utilisée pour exporter votre portefeuille vers d'autres applications de portefeuille Decred.

**Ne pas conserver votre graine de façon privée et sécurisée pourrait entrainer le vol de l'intégralité de votre portefeuille. Vous ne devez en aucun cas révéler votre graine à quiconque.**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- façon privée et < sécurisée | sécuritaire >

"vsptickets.table.header.price": "Prix",
"vsptickets.table.header.purchased": "Acheté",
"vsptickets.table.header.status": "Statut Ticket",
"vsptickets.tickettypes.tooltip": "Statut Ticket",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- Statut [du] Ticket

"watchOnly.enabled": "Lecture seule",
"watchOnly.warn": "Cette fonctionnalité est désactivée pour les portefeuilles en lecture seule"
"watchOnly.enabled": "Consultation seule (watch-only) ",
"watchOnly.warn": "Cette fonctionnalité est désactivée pour les portefeuilles en consultation seule (watch-only)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- Cette < fonctionnalité | fonction > est désactivée

"vsptickets.table.header.purchased": "Acheté",
"vsptickets.table.header.status": "Statut Ticket",
"vsptickets.tickettypes.tooltip": "Statut Ticket",
"vsptickets.type.all": "Tout",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- < Tout | Tous >

* Nous avons ajouté des nouveaux outils qui devraient réduire les
demandes de support les plus courantes. Premièrement, lors de la restauration
d'un portefeuille depuis une graine, les utilisateurs ont maintenant l'option de
'désactiver la mise à jour du type de jeton' ce qui va autoriser les anciens portefeuilles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- type de < jeton' | monnaie > ce qui va

demandes de support les plus courantes. Premièrement, lors de la restauration
d'un portefeuille depuis une graine, les utilisateurs ont maintenant l'option de
'désactiver la mise à jour du type de jeton' ce qui va autoriser les anciens portefeuilles
(avant 2017) d'être restauré avec le type jeton précédent. Nous avons aussi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- < jeton |monnaie >

@xaur
Copy link
Contributor

xaur commented Oct 3, 2023

Thanks for your epic translation and review @JaseurPattu and @nnnko56 !

@nnnko56 do I understand correctly that the most urgent fixes we need to make this translation release-ready are the 5 items listed in the Before Next Release section of your comment, while everything else can be polished in future PRs?

Totally agree about standardization of terms. We will save time if we do it once and document non-trivial terms, recommended translations, and any reasoning or comments for them. We can put it all in this French document before doing the next polishing PR.

@nnnko56
Copy link

nnnko56 commented Oct 4, 2023

Thanks for your epic translation and review @JaseurPattu and @nnnko56 !

@nnnko56 do I understand correctly that the most urgent fixes we need to make this translation release-ready are the 5 items listed in the Before Next Release section of your comment, while everything else can be polished in future PRs?

Yes the 5 items are the ones I recommend be fixed before the next release because the meaning is not accurate and could lead to confusion. Of the 5 , 4 are sentence replacement and I provided alternatives I believe are suitable.

The other issue is the use of the word "jeton" (token). I know it's often a a sensitive subject in chats because Decred is a currency (Money) with it's own blockchain and not a token which often refers to (ETH tokens). So we may want to not call Decred a token (jeton) in our official docs, but it's more work because it means replacing multiple lines. I tried to make line comments and review each occurrence but I may have missed some and there may be other occurrences outside of this PR so so it may or may not be as urgent to fix depending on the required work and the time available.,

@JaseurPattu
Copy link
Author

First of all, many thanks for the review @nnnko56, I'm really happy to see this PR moving forward !

I agree with both of you and think it is wise to focus on the 5 keys things you have identified.

As referred by @xaur, I started a standardization page to describe keys translation decisions and this page has determined the translation of some blockchain/technical terms in this work.
Following you review, I will update it and keep it in sync to reflect latest decisions.

About the "coin" translation:
To be honest, it was complicated to me to decide between the terms "monnaie", "jeton" or even "pièce".
Back then, I have chosen to follow the french legal/fiscal point of view where cryptocurrencies are not recognized as a official money but as tokens (same has collector gold coins in fact).
I will of course update to "monnaie" as you requested but at least you have now the rationale for the decision !

Please note that a lot of labels are not in english translation file and are specified only in UI screens files.
While testing Decrediton and translation, I have added intentionally these translations in order to avoid having a mix of english/french on screens. So, it is important to keep them to have the best user experience.
Unfortunately, I had no time to add them in english translation file but that would be an effort to do ideally as it would be beneficial for other languages too.

For other comments, I have overall no objections on most of them, but I will comment back if I need some clarification or to discuss your proposal.

I agree that "stak*" terms are the worse to translate, and moreover they sound bad in french !
By chance, would you be available to chat about them one day ?

@xaur
Copy link
Contributor

xaur commented Oct 7, 2023

a lot of labels are not in english translation file and are specified only in UI screens files. While testing Decrediton and translation, I have added intentionally these translations in order to avoid having a mix of english/french on screens. So, it is important to keep them to have the best user experience.

@JaseurPattu which strings do you refer to? Do you mean you've added French strings to app/i18n/translations/fr.json which are not currently used because they are hardcoded in UI code?

@xaur
Copy link
Contributor

xaur commented Oct 7, 2023

Unfortunately, I had no time to add them in english translation file but that would be an effort to do ideally as it would be beneficial for other languages too.

Right, but let's leave that for other PRs. We want this PR to have minimum conflicts to be easier to merge.

@JaseurPattu
Copy link
Author

a lot of labels are not in english translation file and are specified only in UI screens files. While testing Decrediton and translation, I have added intentionally these translations in order to avoid having a mix of english/french on screens. So, it is important to keep them to have the best user experience.

@JaseurPattu which strings do you refer to? Do you mean you've added French strings to app/i18n/translations/fr.json which are not currently used because they are hardcoded in UI code?

What I was referring to is that some entries in the UI code are missing in the english translation.
I have added them as entries in the french translation to have them in french (no UI code change required, it works out of the box)

For instance:
Label with key: "confDialog.signTransaction.message"
Is defined in UI code here along with its default english text: https://github.com/decred/decrediton/blob/master/app/wallet/confirmationDialog/signTx.js#L24
But cannot be found in original.json: https://github.com/decred/decrediton/blob/master/app/i18n/translations/original.json

@JaseurPattu
Copy link
Author

Unfortunately, I had no time to add them in english translation file but that would be an effort to do ideally as it would be beneficial for other languages too.

Right, but let's leave that for other PRs. We want this PR to have minimum conflicts to be easier to merge.

Yes, it is clearly out of scope of this PR

@xaur
Copy link
Contributor

xaur commented Oct 10, 2023

v1.8.1 is out but we may have a v1.8.2 with patches for Ledger, we might jump into that. @JaseurPattu please check the chat when you get a chance.

Copy link

@nnnko56 nnnko56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job fixing not only the 5 more "critical" elements from the first PR but all other issues as well.

A merge is good to go! I'm left with only 5 minor and non-urgent line comments that can be fixed now or later on

@@ -1,18 +1,18 @@
Stakeshuffle nécessite deux comptes dédiés - un compte "mixé" et un compte
"non mixé".

Quand le mixer est activé, Decred va faire des transferts des fonds depuis le compte non mixé
Quand le mixeur est activé, Des Decred seront transférés depuis le compte non mixé
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< Des | des >

@@ -488,14 +487,14 @@
"home.currentTotalLockedBalanceLabel": "Verrouillé",
"home.currentTotalSpendableBalanceLabel": "Disponible",
"home.currentTotalUnconfirmedBalanceLabel": "Non Confirmé",
"home.earned": "{value} ont été gagnés en récompenses de staking",
"home.earned": "{value} ont été gagnés en récompenses de d'enjeu",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

récompense {de} d'enjeu

"mixerSettings.gotIt": "J'ai compris",
"modal.complete.registration.process": "Terminer le processus d'enregistrement",
"modal.go.to.tickets.status": "Consulter le statut du ticket",
"myTicket.syncVSP": "Échec de la synchronisation des tickets du VSP",
"myTickets.loadingMoreTickets": "Chargement d'autres tickets...",
"myTickets.loadingMoreTicketsProgressAsc": "Bloc ascendant {block} ({blockPerc, number, percent})",
"myTickets.loadingMoreTicketsProgressDesc": "Bloc descendant {block} ({blockPerc, number, percent})",
"myTickets.noloadingMoreTickets": "Chargement de plus de tickets annulé",
"myTickets.noloadingMoreTickets": "Chargement de plus de tickets annulés",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was wrong on this one.
C'est le chargement qui est annulé, on ne parle pas de "tickets annulés"

@@ -1450,7 +1433,7 @@
"transactions.tab.send": "Envoyer",
"transactions.title": "Transactions",
"transactions.txtypes.tooltip": "Type de transaction",
"treasurySpending.description": "Toute dépense des fonds du trésor nécessite à présent un vote des stakeholders. Pour chaque clé Politeia ou transaction de type Tspend, vous pouvez voter et indiquer votre choix à propos de la dépense. Les clés peuvent être vérifiées en consultant le {link}.",
"treasurySpending.description": "Toute dépense des fonds du trésor nécessite à présent un vote des participants à l'enjeu. Vous pouvez participer et définir un stratégie de vote pour les dépense imputées au Trésor par une clé Politeia spécifique ou pour les transaction de type Tspend. Les clés peuvent être vérifiées en consultant le {link}.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

définir un[e] stratégie de vote

"tutorials.powPos.label2": "PdE (PoS)",
"tutorials.powPos.label3": "Hybridation PdT/PdE",
"tutorials.powPos.title1": "1 CPU, 1 Vote – Preuve-de-Travail",
"tutorials.powPos.title2": "1 Monnaie, 1 Vote – Preuve-d'Enjeu",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans ce cas-ci peut-être que "pièce" serait plus approprié, aussi puisqu'on ne parle pas spécifiquement de Decred mais bien du concept général de la preuve d'enjeu, "jeton" serait aussi acceptable je crois.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, pièce sonne mieux, j'avais hésité à mettre "Monnaie" ici.

@JaseurPattu
Copy link
Author

And here is the correction for the last few things noticed during the last review.
Thanks for the approval @nnnko56 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants