Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/did manager add/remove key/service sign only and submit from other controller agent (#5) #1378

Closed
wants to merge 0 commits into from

Conversation

radleylewis
Copy link
Contributor

What issue is this PR fixing

Closes #1373

What is being changed

Due to constraints within the secure MetaMask Snap context, it is not possible to invoke the didManagerAdd(Remove)Service or didManagerAdd(Remove)Key methods on the did-manager successfully. Refer here for the list of blocked RPC methods.

As outlined in the referenced issue, the changes proposed herein allow for the transaction to be signed within one agent (in the demonstration case, by an agent in the constrained MetaMask Snap environment), and then submitted from another agent to the network in another context (in the demonstrated case this is a nodejs server, not subject to the constraints of the MetaMask Snap).

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because I first want to have the code reviewed by the maintainers, to get their feedback on the approach, and am happy to add tests as part of the final PR.

Details

I have successfully tested this (with the did-ethr-provider on the sepolia testnet). See resulting public DIDDoc below (with added ed25519 key and a mock service endpoint).
image

@radleylewis radleylewis changed the title Feat/did manager add key sign only (#5) Feat/did manager add/remove key/service sign only and submit from other controller agent (#5) Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow signed addKey/addService return type for later submission by other agent
1 participant