Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use controller registrar from transactions #2615

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Apr 25, 2023

Closes #2562

I created getContractAddressForAppChainId to obtain the corresponding contract for the CHAIN_ID defined in the dev|prod|stg.json files. It would work for Ethereum only contracts which is enough for this case.

Currently failing because decentraland/decentraland-transactions#67 needs to be resolved first

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:28pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4802388124

  • 4 of 9 (44.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 16.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/ens/utils.ts 0 1 0.0%
src/modules/ens/sagas.ts 3 7 42.86%
Totals Coverage Status
Change from base Build 4755988459: -0.004%
Covered Lines: 3064
Relevant Lines: 14441

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Registry and Controller from decentraland-transactions
2 participants