Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon/manifest #193

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

missmatsuko
Copy link
Contributor

Generates favicon/web app icon from single source SVG and adds web app manifest.
Closes #191

What kind of change does this PR introduce?

Feature

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@ZoltanVeres
Copy link
Collaborator

@missmatsuko The build for your first push was 6 mins and the second push took 10 mins to deploy.
Honestly not sure if this is Netlify related or the plugin has its own issues. May i ask how this affected the build time on your own repo?

@missmatsuko
Copy link
Contributor Author

I was looking at the build scripts and I think build is going to delete all the files in public regardless if they were committed or not? This might be why committing the generated files aren't having an affect on build time.

"clean": "rimraf .cache public",
"build": "npm run clean && gatsby build",

@missmatsuko
Copy link
Contributor Author

I took a look at the gatsby-plugin-manifest, and I think it doesn't check if generated files already exist before running. Make an issue on Gatsby to see if they might want to add this feature:
gatsbyjs/gatsby#12506

@ZoltanVeres
Copy link
Collaborator

@missmatsuko First of all, thank for taking the time to figure out this issue. We appreciate each PR, I think our problem in the starter is that we should fix the caching in the build process, and an ideal tool would be to use gatsby-plugin-netlify-cache, but i would wait until this issue is cleared. axe312ger/gatsby-plugin-netlify-cache#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add favicon/manifest
2 participants