Fix typings for EditorComponentField #7160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasandresen
changed the title
|
I just ran into this same issue when referencing the documentation for registering an editor component: |
|
@mathiasandresen great fix! |
demshy
approved these changes
Mar 28, 2024
|
released as decap-cms@3.1.5 |
yuri-g-taboola
pushed a commit
to taboola/decap-cms
that referenced
this pull request
May 22, 2024
* fix: make EditorComponentField type handle widget='list' correctly * fix: make field and fields optional for widget='list' --------- Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was not possible for me to add new widgets with correct typing, since I was required to set
fieldandfieldsfor non 'list' widgets.So I modified the types to be a discriminated union, that only allows setting
fieldandfieldwhen widget is equal to'list'.Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)