Potential Fix for #7152 (Slate crashing) (#7153)

* Potential Fix for #7152 * fix: update e2e tests for soft breaks --------- Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
decaporg · Mar 28, 2024 · e67e067 · e67e067
1 parent 4262b63
commit e67e067
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/cypress/e2e/markdown_widget_enter_spec.js b/cypress/e2e/markdown_widget_enter_spec.js
@@ -89,7 +89,7 @@ describe('Markdown widget breaks', () => {
         .enter({ shift: true })
         .confirmMarkdownEditorContent(`
           <p>
-
+            <br>
           </p>
         `);
     });
@@ -98,7 +98,10 @@ describe('Markdown widget breaks', () => {
         .enter({ shift: true, times: 4 })
         .confirmMarkdownEditorContent(`
           <p>
-
+            <br>
+            <br>
+            <br>
+            <br>
           </p>
         `);
     });

diff --git a/package.json b/package.json
@@ -15,8 +15,7 @@
     "test:unit": "cross-env NODE_ENV=test jest --no-cache",
     "test:e2e": "npm run build:demo && npm run test:e2e:run",
     "test:e2e:ci": "npm run build:demo && npm run test:e2e:run-ci",
-    "test:e2e:dev": "run-p test:e2e:start test:e2e:exec-dev",
-    "test:e2e:start": "start-test develop 8080",
+    "test:e2e:dev": "start-test develop 8080 test:e2e:exec-dev",
     "test:e2e:serve": "http-server -c-1 dev-test",
     "test:e2e:exec": "cypress run --browser chrome --headless",
     "test:e2e:exec-ci": "node cypress/run.mjs",

diff --git a/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js b/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js
@@ -205,7 +205,12 @@ function ThematicBreak(props) {
 }
 
 function Break(props) {
-  return <br {...props.attributes} />;
+  return (
+    <>
+      <br {...props.attributes} />
+      {props.children}
+    </>
+  );
 }
 
 function BulletedList(props) {