[netbox] Improve superuser account creation #2488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-304
force-pushed
the
netbox-superuser-upstream
branch
from
c6d107f
to
58c3ae1
Compare
k-304
force-pushed
the
netbox-superuser-upstream
branch
3 times, most recently
from
7591c80
to
e5dc5e5
Compare
k-304
force-pushed
the
netbox-superuser-upstream
branch
from
e5dc5e5
to
7d455a1
Compare
|
your proposition look good to me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a superuser is not idempotent. Since it is based on the
migrationoutput, it may be run when performing NetBox updates (at this time, the user does exist already). The task will fail and stop the update.This change adds a check if the superuser is present or not. Depending on this (rather than depending on the migration task output), a user will be created or the task skipped.