Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for ferm_parsed_rules #2463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julien-lecomte
Copy link
Contributor

Without this, the play can error out with a "Unable to look up a name or access an attribute in template string"

Without this, the play can error out with a "Unable to
look up a name or access an attribute in template string"
@goetzk
Copy link

goetzk commented Jan 4, 2024

Ah, thanks for opening this PR - I started having this issue recently!

Its not obvious to me why this has started happening (the affected code hadn't changed in some time). I wonder if its a combination of commit dc938e1 and some recent change to ansible.

Anyway, thanks for proposing this fix!

Edit: This affects me on version 3.0.5 of the collection using ansible-core 2.15.4 and python 3.11.2

@drybjed
Copy link
Member

drybjed commented Jan 17, 2024

I'd like to replicate the issue so that I can check what's the underlying problem. Can you give me details about the environment in which this happens? The error message you get from Ansible, for example. Did you set anything ferm-related in the Ansible inventory? Check all the files to be sure: grep -r 'ferm__' ansible/iventory/*.

@drybjed drybjed added bug something is not working as expected priority: high tag: firewall labels Jan 17, 2024
@drybjed drybjed added this to the DebOps v3.2.0 milestone Jan 17, 2024
@julien-lecomte
Copy link
Contributor Author

We're getting this issue with our inventory with every new VM we're trying to configure. My colleage got it yesterday, and wasn't aware of the issue, and posted this error message on our internal boards:

MicrosoftTeams-image

@drybjed
Copy link
Member

drybjed commented Jan 18, 2024

The messages point out to a variable which is undefined. Debugging this might be difficult via back and forth issue messages. Can we set up a TeamViewer session so that I can see the environment in question and I'm ablle to check the state of various variables? I can do it usually after 16:00 UTC on workdays. Contact me via Matrix/Element DebOps channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is not working as expected priority: high tag: firewall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants