Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pid max 32bits #2440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix pid max 32bits #2440

wants to merge 2 commits into from

Conversation

prahal
Copy link
Contributor

@prahal prahal commented Oct 18, 2023

Only ship sysctl pid-max conf with pid-max set to 2^22 to 64bits archs.

First add the is_64bits fact to debops.core.

@prahal
[core] add is_64bits fact
25734a1 
This fact is true if the architecture maximum word size is above 32
bits. Else it is false.
@prahal
[sysctl] do not ship 50-pid-max.conf on 32 bits architectures
8d200e1 
For 32 bits arch pid_max maximum value is 32768.
With 50-pid-max.conf value of 4194304 sysctl errors out.

See man 5 proc:
On 32-bit platforms, 32768 is the maximum value for pid_max.

Closes debops#2051
@prahal prahal requested a review from drybjed as a code owner October 18, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drybjed drybjed Awaiting requested review from drybjed drybjed is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prahal