postgresql role is broken with multiple problems

[ser]

Hello, as Postgresql.org introduced replacement of GPG keys IDs with GPG files in its apt repository, postgresql debops role is broken and is not able to install required packages.

I have found a pretty dirty workaround, firstly manually downloading required key file:

curl -o /etc/apt/keyrings/postgresql.org.asc --fail https://www.postgresql.org/media/keys/ACCC4CF8.asc

and then making following entries to debops configuration (I use debian sid):

postgresql_server__upstream_apt_repo: 'deb [signed-by=/etc/apt/keyrings/postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt/ sid-pgdg main 16'
postgresql_server__upstream_key_id: '1505 8500 A023 5D97 F5D1  0063 B188 E2B6 95BD 4743'
postgresql__upstream_key_id: '1505 8500 A023 5D97 F5D1  0063 B188 E2B6 95BD 4743'
postgresql__upstream_apt_repo: 'deb [signed-by=/etc/apt/keyrings/postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt/ sid-pgdg main 16'

The key 1505 8500 A023 5D97 F5D1 0063 B188 E2B6 95BD 4743 can by any random valid key you trust - it is here just to overcome problems with non-existence of default key ID specified in postgresql role.

required changes for version 16

It's also required to remove vacuum_defer_cleanup_age from /etc/postgresql/16/main/postgresql.conf created by the role, as this parameter is not available in PG16.