-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-7862 Updated MongoDB connector docs to reflect replica_set connection mode removal #5556
Conversation
Needs to be backported to 2.6! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and questions.
@roldanbob Accepted all suggestions except for the two remaining |
Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
@jcechace I updated my comments in response to your review. |
Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
…tion mode removal
Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
@jpechane @roldanbob I've consolidated the changes. From my POV it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jcechace I made another pass, and found a few more things.
Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just saw your latest comment. Your latest comment makes sense. Updated the comment for L249, so if you implement that, I think we can merge this. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I previously signaled approval for this, but then saw Jakub's comment about L249. After that change is committed, I think that this is ready to go.
Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
Co-authored-by: roldanbob <broldan@redhat.com>
https://issues.redhat.com/browse/DBZ-7862
@roldanbob Feel free to update as you see fit.